Horton

Re: Handle infinite recursion in logical replication setup

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-05-26T05:08:42Z
Lists: pgsql-hackers 
On Thu, May 26, 2022 at 7:06 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
>
> 3. doc/src/sgml/catalogs.sgml
>
> +      <para>
> +       If true, the subscription will request that the publisher send locally
> +       originated changes. False indicates that the publisher sends any changes
> +       regardless of their origin.
> +      </para></entry>
>
> SUGGESTION
> If true, the subscription will request the publisher to only send
> changes that originated locally.
>
> ~~~
>

I think it is a good idea to keep the description related to the
'False' value as without that it is slightly unclear.

> 4. doc/src/sgml/ref/create_subscription.sgml
>
> +         <para>
> +          Specifies whether the subscription will request the publisher to send
> +          locally originated changes at the publisher node, or send any
> +          publisher node changes regardless of their origin. The default is
> +          <literal>false</literal>.
> +         </para>
>
> This wording should be more similar to the same information in catalogs.sgml
>
> SUGGESTION
> Specifies whether the subscription will request the publisher to only
> send changes that originated locally, or to send any changes
> regardless of origin.
>
> ~~~
>

Here, also, let's keep the wording related to the default value.

-- 
With Regards,
Amit Kapila.

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues