Re: Add 'worker_type' to pg_stat_subscription

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Maxim Orlov <orlovmg@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-09-21T10:31:20Z
Lists: pgsql-hackers
On Thu, Sep 21, 2023 at 1:00 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Tue, Sep 19, 2023 at 08:36:35AM +0530, Amit Kapila wrote:
> > I am of the opinion that worker_type should be 'apply' instead of
> > 'leader apply' because even when it is a leader for parallel apply
> > worker, it could perform individual transactions apply. For reference,
> > I checked pg_stat_activity.backend_type, there is nothing called main
> > or leader backend even when the backend is involved in parallel query.
>
> Okay.  Here is v9 of the patch with this change.
>

The changes looks good to me, though I haven't tested it. But feel
free to commit if you are fine with this patch.

-- 
With Regards,
Amit Kapila.



Commits

  1. Add worker type to pg_stat_subscription.

  2. Simplify determining logical replication worker types.