Re: pgsql: Document XLOG_INCLUDE_XID a little better
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-03T03:10:26Z
Lists: pgsql-hackers
On Thu, Oct 28, 2021 at 8:15 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Wed, Oct 27, 2021 at 4:39 PM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > > > On Tue, Oct 26, 2021 at 9:19 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > > > > > > Thanks, both your patches look good to me except that we need to > > > > remove the sentence related to the revert of ade24dab97 from the > > > > commit message. I think we should backpatch the first patch to 14 > > > > where it was introduced and commit the second patch (related to moving > > > > code out of critical section) only to HEAD but we can even backpatch > > > > the second one till 9.6 for the sake of consistency. What do you guys > > > > think? > > > > > > > > > > The other option could be to just commit both these patches in HEAD as > > > there is no correctness issue here. > > > > Right, even I feel we should just commit it to the HEAD as there is no > > correctness issue. > > > > Thanks for your opinion. I'll commit it to the HEAD by next Tuesday > unless someone feels that we should backpatch this. > Pushed. -- With Regards, Amit Kapila.
Commits
-
Move MarkCurrentTransactionIdLoggedIfAny() out of the critical section.
- 335397456b7e 15.0 landed
-
Replace XLOG_INCLUDE_XID flag with a more localized flag.
- 71db6459e6e4 15.0 landed
-
Document XLOG_INCLUDE_XID a little better
- c1d1ae1db237 14.0 cited
- ade24dab97a2 15.0 cited
-
Immediately WAL-log subtransaction and top-level XID association.
- 0bead9af484c 14.0 cited