Horton

Re: [PATCH] add concurrent_abort callback for output plugin

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: Ajin Cherian <itsajin@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-01T03:30:09Z
Lists: pgsql-hackers 
On Wed, Mar 31, 2021 at 7:20 PM Markus Wanner
<markus.wanner@enterprisedb.com> wrote:
>
> On 31.03.21 15:18, Amit Kapila wrote:
> > On Wed, Mar 31, 2021 at 11:55 AM Markus Wanner
> >> The last sentences there now seems to relate to just the setting of
> >> "concurrent_abort", rather than the whole reason to invoke the
> >> prepare_cb.  And the reference to the "gid" is a bit lost.  Maybe:
> >>
> >>      "Thus even in case of a concurrent abort, enough information is
> >>       provided to the output plugin for it to properly deal with the
> >>       <command>ROLLBACK PREPARED</command> once that is decoded."
> >
> > Okay, Changed the patch accordingly.
>
> That's fine with me.
>

Pushed.

-- 
With Regards,
Amit Kapila.

Commits

  1. Avoid sending prepare multiple times while decoding.

  2. Ensure to send a prepare after we detect concurrent abort during decoding.