Re: pgsql: Prevent invalidation of newly synced replication slots.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>, Amit Kapila <akapila@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-28T15:00:45Z
Lists: pgsql-hackers
Attachments
- quit_sessions_2.patch (application/octet-stream) patch
On Wed, Jan 28, 2026 at 6:28 PM Robert Haas <robertmhaas@gmail.com> wrote: > > On Wed, Jan 28, 2026 at 7:35 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > Does this fix/theory sound plausible? > > I wondered about this yesterday, too. I didn't actually understand how > the existence of the background psql could be causing the failure, but > I thought it might be. However, I couldn't figure out the correct > incantation to get rid of it in my testing, as I thought I would need > to detach the injection point first or something. > Yeah, it would be better to quit these sessions after the test is complete because there are other two background sessions as well. I used the method to quit these sessions as used in \src\test\modules\test_misc\t\005_timeouts.pl. The attached passes for me on both Linux and Windows (check on HEAD only as of now). I'll do some more testing on back branches as well and push tomorrow morning if there are no more comments. -- With Regards, Amit Kapila.
Commits
-
Fix CI failure introduced in commit 851f6649cc.
- 1c60f7236368 18.2 landed
- 3a98f989e8e5 19 (unreleased) landed
- 9649f1adfdee 17.8 landed
-
Prevent invalidation of newly synced replication slots.
- 851f6649cc18 19 (unreleased) cited
-
Prevent invalidation of newly created replication slots.
- 006dd4b2e5b3 19 (unreleased) cited