Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Japin Li <japinli@hotmail.com>
Date: 2021-08-09T03:09:44Z
Lists: pgsql-hackers
On Sat, Aug 7, 2021 at 6:53 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote: > > On Sat, Aug 7, 2021 1:36 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Fri, Aug 6, 2021 at 9:57 PM Japin Li <japinli@hotmail.com> wrote: > > > > Do you mean to say that do it for both Add and Drop or just for Drop? > > Actually, doing it both will make the behavior consistent but doing it just for > > Drop might be preferable by some users. I think it is better to be consistent here > > but I am fine if you and others feel it is better to refresh all publications only in > > Drop case. > > Personally, I also think it will be better to make the behavior consistent. > Attach the new version patch make both ADD and DROP behave the same as SET PUBLICATION > which refresh all the publications. > There is a bug reported on pgsql-bugs [1] which seems to be happening due to the same reason. Can you please test that the other bug is also fixed with your patch? [1] - https://www.postgresql.org/message-id/17132-6a702189086c6243%40postgresql.org -- With Regards, Amit Kapila.
Commits
-
Fix Alter Subscription's Add/Drop Publication behavior.
- 5cfcd46e9d29 14.0 landed
- 1046a69b3087 15.0 landed
-
ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION
- 82ed7748b710 14.0 cited