Re: Confusing comment for function ExecParallelEstimate

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>

To: "Wu, Fei" <wufei.fnst@cn.fujitsu.com>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-06-06T02:42:36Z

Lists: pgsql-hackers

On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei <wufei.fnst@cn.fujitsu.com> wrote:
>
> Sorry, Last mail forget to CC the mailing list.
>
> Now the comment is confusing, Maybe someone should correct it.
>

Sure, for the sake of clarity, when this code was initially introduced
in commit d1b7c1ff, the structure used was
SharedPlanStateInstrumentation, but later when it got changed to
Instrumentation structure in commit b287df70, we forgot to update the
comment.  So, we should backpatch this till 9.6 where it got
introduced.  I will commit this change by tomorrow or so.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

Fix inconsistency in comments atop ExecParallelEstimate.
- 5afb57038f33 9.6.14 landed
- fac1ed274293 10.9 landed
- 17aa054a7996 11.4 landed
- d8261595bc6f 12.0 landed
Allow EXPLAIN (ANALYZE, VERBOSE) to display per-worker statistics.
- b287df70e408 9.6.0 cited
Parallel executor support.
- d1b7c1ffe72e 9.6.0 cited