Re: Proposal: Conflict log history table for Logical Replication
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-05T05:25:44Z
Lists: pgsql-hackers
On Fri, May 1, 2026 at 7:16 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> I have fixed all the reported comments except these four.
> 1. I'm changing the ConflictLogDest enum from bitmap to integer. I can
> revert this in the next version but I want to see Peter's opinion
> first, as he suggested using a bitmap to easily apply bitwise
> operators.
>
But that created an array size inconvenience. If you want to wait for
more comments, I suggest you can keep it as a top-up patch immediately
after the patch where it is introduced.
Other points:
*
subscription’s lifecycle.
I saw the above funny character in 0002's commit message.
*
+
+ ereport(NOTICE,
+ (errmsg("created conflict log table pg_conflict.\"%s\" for
subscription \"%s\"",
+ relname, subname)));
I think we can use a new function introduced by 0001 to get a
qualified relname instead of doing it manually here.
--
With Regards,
Amit Kapila.