Re: Add an option to skip loading missing publication to avoid logical replication failure
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-10T04:02:56Z
Lists: pgsql-hackers
On Tue, Mar 4, 2025 at 6:54 PM vignesh C <vignesh21@gmail.com> wrote: > > On further thinking, I felt the use of publications_updated variable > is not required we can use publications_valid itself which will be set > if the publication system table is invalidated. Here is a patch for > the same. > The patch relies on the fact that whenever a publication's data is invalidated, it will also invalidate all the RelSyncEntires as per publication_invalidation_cb. But note that we are discussing removing that inefficiency in the thread [1]. So, we should try to rebuild the entry when we have skipped the required publication previously. Apart from this, please consider updating the docs, as mentioned in my response to Sawada-San's email. BTW, I am planning to commit this only on HEAD as this is a behavior change. Please let me know if you guys think otherwise. [1] - https://www.postgresql.org/message-id/OSCPR01MB14966C09AA201EFFA706576A7F5C92%40OSCPR01MB14966.jpnprd01.prod.outlook.com -- With Regards, Amit Kapila.
Commits
-
Fix the race condition in the test added by 7c99dc587.
- 8ede692de512 18.0 landed