Horton

Re: Inconsistency in determining the timestamp of the db statfile.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Magnus Hagander <magnus@hagander.net>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-10T07:05:01Z
Lists: pgsql-hackers

Attachments

On Thu, Sep 10, 2020 at 11:52 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
>
>
> Regarding the v2 patch, I think we should return false in the
> following case too:
>
>             default:
>                 ereport(pgStatRunningInCollector ? LOG : WARNING,
>                         (errmsg("corrupted statistics file \"%s\"",
>                                 statfile)));
>                 goto done;
>

makes sense, attached find the updated patch.

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix inconsistency in determining the timestamp of the db statfile.

  2. Split pgstat file in smaller pieces