Re: Data is copied twice when specifying both child and parent table in publication
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>,
Amit Langote <amitlangote09@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-18T06:00:43Z
Lists: pgsql-hackers
On Mon, Oct 18, 2021 at 8:27 AM Greg Nancarrow <gregn4422@gmail.com> wrote: > > On Sat, Oct 16, 2021 at 5:30 PM houzj.fnst@fujitsu.com > <houzj.fnst@fujitsu.com> wrote: > > > > On Friday, October 15, 2021 7:23 PM houzj.fnst@fujitsu.com wrote: > > > Attach a patch to fix it. > > Attach a new version patch which refactor the fix code in a cleaner way. > > > > I have not debugged it yet to find out why, but with the patch > applied, the original double-publish problem that I reported > (converted to just use TABLE rather than ALL TABLES IN SCHEMA) still > occurs. > Yeah, I think this is a variant of the problem being fixed by Hou-San's patch. I think one possible idea to investigate is that on the subscriber-side, after fetching tables, we check the already subscribed tables and if the child tables already exist then we ignore the parent table and vice versa. We might want to consider the case where a user has toggled the "publish_via_partition_root" parameter. It seems both these behaviours/problems exist since commit 17b9e7f9 (Support adding partitioned tables to publication). Adding Amit L and Peter E (people involved in this work) to know their opinion? -- With Regards, Amit Kapila.
Commits
-
Avoid syncing data twice for the 'publish_via_partition_root' option.
- 062a84442424 16.0 landed
-
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 52d5ea9adb01 14.5 cited
-
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
-
Fix double publish of child table's data.
- 3f06c00cf6dc 13.6 landed
- 614b77d65a38 14.2 landed
- 5e97905a2c76 15.0 landed
-
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 cited