Re: Fix an incorrect statement for failover option in alter_subscription.sgml
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
Date: 2024-07-22T10:54:55Z
Lists: pgsql-docs
On Mon, Jul 22, 2024 at 10:45 AM shveta malik <shveta.malik@gmail.com> wrote: > > On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu) > <houzj.fnst@fujitsu.com> wrote: > > > > Hi, > > > > The documentation incorrectly stated that users cannot alter subscription's > > failover option when two-phase commit is enabled. > > > > When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET > > (failover) in a transaction block, but I missed the following statement for > > two-phase commit which causes the incorrect understanding. Here is a small > > patch to fix it. > > The patch looks good to me except there is repetition of commands in > both the lines now. But I could not think of a better way. So I think > it is okay to have this way. > Thanks for the review. I also couldn't think of a better way to document this information. The patch as proposed looks good to me. -- With Regards, Amit Kapila.
Commits
-
Doc: Fix the mistakes in the subscription's failover option.
- 20aaa634f72a 17.0 landed
- 07fbecb87b16 18.0 landed