Re: Invalidate the subscription worker in cases where a user loses their superuser status

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Jeff Davis <pgsql@j-davis.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-10-12T05:40:36Z
Lists: pgsql-hackers
On Sun, Oct 8, 2023 at 8:22 AM vignesh C <vignesh21@gmail.com> wrote:
>

--- a/src/include/catalog/pg_subscription.h
+++ b/src/include/catalog/pg_subscription.h
@@ -127,6 +127,7 @@ typedef struct Subscription
  * skipped */
  char    *name; /* Name of the subscription */
  Oid owner; /* Oid of the subscription owner */
+ bool ownersuperuser; /* Is the subscription owner a superuser? */
  bool enabled; /* Indicates if the subscription is enabled */
  bool binary; /* Indicates if the subscription wants data in
  * binary format */

We normally don't change the exposed structure in back branches as
that poses a risk of breaking extensions. In this case, if we want, we
can try to squeeze some padding space or we even can fix it without
introducing a new member. OTOH, it is already debatable whether to fix
it in back branches, so we can even commit this patch just in HEAD.

Thoughts?

-- 
With Regards,
Amit Kapila.



Commits

  1. Restart the apply worker if the privileges have been revoked.