Re: [PATCH] Provide more information to filter_prepare

On Thu, Mar 25, 2021 at 2:07 PM Markus Wanner
<markus.wanner@enterprisedb.com> wrote:
>
> On 22.03.21 09:50, Markus Wanner wrote:
> > thank you for reconsidering this patch.  I updated it to include the
> > required adjustments to the documentation.  Please review.
>
> I tweaked the wording in the docs a bit, resulting in a v3 of this patch.
>

One minor comment:
-      The callback has to provide the same static answer for a given
-      <parameter>gid</parameter> every time it is called.
+       The callback may be invoked several times per transaction to decode and
+       must provide the same static answer for a given pair of

Why do you think that this callback can be invoked several times per
transaction? I think it could be called at most two times, once at
prepare time, then at commit or rollback time. So, I think using
'multiple' instead of 'several' times is better.

-- 
With Regards,
Amit Kapila.