Horton

Re: Logical WAL sender unresponsive during decoding commit

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-10-22T10:57:50Z
Lists: pgsql-hackers 
On Thu, Oct 20, 2022 at 7:17 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Oct 20, 2022 at 1:37 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Thu, Oct 20, 2022 at 5:17 AM Robert Haas <robertmhaas@gmail.com> wrote:
> > > > Pushed.
> > >
> > > I think this was a good change, but there's at least one other problem
> > > here: within ReorderBufferRestoreChanges, the while (restored <
> > > max_changes_in_memory && *segno <= last_segno) doesn't seem to contain
> > > a CFI. Note that this can loop either by repeatedly failing to open a
> > > file, or by repeatedly reading from a file and passing the data read
> > > to ReorderBufferRestoreChange. So I think there should just be a CFI
> > > at the top of this loop to make sure both cases are covered.
> >
> > Agreed. The failures due to file operations can make this loop
> > unpredictable in terms of time, so it is a good idea to have CFI at
> > the top of this loop.
> >
> > I can take care of this unless there are any objections or you want to
> > do it. We have backpatched the previous similar change, so I think we
> > should backpatch this as well. What do you think?
>
> Please go ahead. +1 for back-patching.
>

Yesterday, I have pushed this change.

-- 
With Regards,
Amit Kapila.

Commits

  1. Add CHECK_FOR_INTERRUPTS while restoring changes during decoding.

  2. Add CHECK_FOR_INTERRUPTS while decoding changes.