Re: row filtering for logical replication
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Sat, Jan 15, 2022 at 12:00 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote: > > On Friday, January 14, 2022 7:31 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Thu, Jan 13, 2022 at 6:46 PM houzj.fnst@fujitsu.com > > > > 9. > > --- a/src/backend/replication/logical/proto.c > > +++ b/src/backend/replication/logical/proto.c > > @@ -15,6 +15,7 @@ > > #include "access/sysattr.h" > > #include "catalog/pg_namespace.h" > > #include "catalog/pg_type.h" > > +#include "executor/executor.h" > > > > Do we really need this include now? Please check includes in other > > files as well and remove if anything is not required. > > ... .... > > Thanks for the comments. > Attach the V65 patch set which addressed the above comments and Peter's comments[1]. The above comment (#9) doesn't seem to be addressed. Also, please check other includes as well. I find below include also unnecessary. --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c ... ... +#include "nodes/nodeFuncs.h" Some other comments: ================== 1. /* + * If we know everything is replicated and some columns are not part + * of replica identity, there is no point to check for other + * publications. + */ + if (pubactions.pubinsert && pubactions.pubupdate && + pubactions.pubdelete && pubactions.pubtruncate && + (!validate_rowfilter || !rfcol_valid)) break; Why do we need to continue for other publications after we find there is an invalid column in row_filter? 2. * For initial synchronization, row filtering can be ignored in 2 cases: + * + * 1) one of the subscribed publications has puballtables set to true + * + * 2) one of the subscribed publications is declared as ALL TABLES IN + * SCHEMA that includes this relation Isn't there one more case (when one of the publications has a table without any filter) where row filtering be ignored? I see that point being mentioned later but it makes things unclear. I have tried to make things clear in the attached. Apart from the above, I have made a few other cosmetic changes atop v65-0001*.patch. Kindly review and merge into the main patch if you are okay with these changes. -- With Regards, Amit Kapila.