Horton

Re: Truncate in synchronous logical replication failed

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Japin Li <japinli@hotmail.com>
Cc: Petr Jelinek <petr.jelinek@enterprisedb.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-16T09:48:31Z
Lists: pgsql-hackers 
On Fri, Apr 16, 2021 at 3:08 PM Japin Li <japinli@hotmail.com> wrote:
>
> On Fri, 16 Apr 2021 at 16:52, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Fri, Apr 16, 2021 at 12:55 PM Japin Li <japinli@hotmail.com> wrote:
> > It is okay as POC but we can't change the existing function
> > RelationGetIndexAttrBitmap. It is used from other places as well. It
> > might be better to write a separate function for this, something like
> > what Osumi-San's patch is trying to do.
>
> Agreed!
>
> Hi Osumi-San, can you merge the test case in your next version?
>

+1. Your test looks reasonable to me.

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix Logical Replication of Truncate in synchronous commit mode.

  2. Logical decoding of TRUNCATE