Re: undetected deadlock in ALTER SUBSCRIPTION ... REFRESH PUBLICATION
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-09T06:46:16Z
Lists: pgsql-hackers
On Fri, Dec 8, 2023 at 7:16 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote: > > > Then let's go with the original patch only. BTW, it took almost the > > same time (105 wallclock secs) in my environment (CentOs VM) to run > > tests in src/test/subscription both with and without the patch. I took > > a median of five runs. I have slightly adjusted the comments and > > commit message in the attached. If you are fine with this, we can > > commit and backpatch this. > > I have tested the patch for all the branches from PG 17 to PG 12. > The same patch applies cleanly on all branches. Also, the same patch > resolves the issue on all the branches. > I ran all the tests and all the tests passed on each branch. > > I also reviewed the patch and it looks good to me. > Thanks, I could also reproduce the issue on back branches (tried till 12), and the fix works. I'll push this on Monday. -- With Regards, Amit Kapila.
Commits
-
Fix an undetected deadlock due to apply worker.
- 8d7d2197f31c 17.0 landed
- 01cc92fa6251 16.2 landed
- 332b43063351 15.6 landed
- 3f86867d560f 14.11 landed
- b47ea4f3d305 13.14 landed
- e81e617f3273 12.18 landed