Horton

Re: Why is subscription/t/031_column_list.pl failing so much?

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Lakhin <exclusion@gmail.com>, Noah Misch <noah@leadboat.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-02-19T08:49:54Z
Lists: pgsql-hackers 
On Thu, Feb 15, 2024 at 10:46 AM vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, 15 Feb 2024 at 08:42, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
>
> > To resolve the BF
> > failure, I still feel, we should just recreate the subscription. This
> > is a pre-existing problem and we can track it via a separate patch
> > with a test case targetting such failures.
>
> +1 for going with recreation of the subscription, the changes for this
> are available at [1].
> [1] - https://www.postgresql.org/message-id/CALDaNm1hLZW4H4Z61swK6WPW6pcNcjzXqw%3D6NqG7e-RMtkFaZA%40mail.gmail.com
>

Tom, and others, does anyone still object to going ahead with an idea
by just changing the test to recreate the subscription to silence BF
failures for this test?

Note that Vignesh has already started a thread [1] to add an option
(or otherwise) to ignore publication lookup failures.

[1] - https://www.postgresql.org/message-id/CALDaNm0-n8FGAorM%2BbTxkzn%2BAOUyx5%3DL_XmnvOP6T24%2B-NcBKg%40mail.gmail.com

-- 
With Regards,
Amit Kapila.

Commits

  1. Back-patch test modifications that were done as part of b6df0798a5.

  2. Fix the intermittent buildfarm failures in 031_column_list.

  3. Fix test race between primary XLOG_RUNNING_XACTS and standby logical slot.

  4. Bound waits in 035_standby_logical_decoding.pl.