Horton

Re: issue with synchronized_standby_slots

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Shlok Kyal <shlok.kyal.oss@gmail.com>, Fabrice Chapuis <fabrice636861@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Alexander Kukushkin <cyberdemn@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-24T09:38:19Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix GUC check_hook validation for synchronized_standby_slots.

  2. Make invalid primary_slot_name follow standard GUC error reporting.

On Fri, Oct 24, 2025 at 1:24 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Shlok,
>
> ```
> -- Can set synchronized_standby_slots to a non-existent slot name.
> ALTER SYSTEM SET synchronized_standby_slots='missing';
> SELECT pg_reload_conf();
>
> -- Reset the GUC.
> ALTER SYSTEM RESET synchronized_standby_slots;
> SELECT pg_reload_conf();
> ```
>
> pg_reload_conf() is called twice here but I'm not sure it is really needed.
> ALTER SYSTEM itself can validate parameters via parse_and_validate_value(elevel=ERROR),
> and pg_reload_conf() won't affect synchronously.

I also think pg_reload_conf() won't be required here.

-- 
With Regards,
Amit Kapila.