Re: Replication slot stats misgivings

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

Date: 2021-04-22T04:49:53Z

Lists: pgsql-hackers

On Thu, Apr 22, 2021 at 8:26 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>

Few comments:
1.
I think we want stats collector to not use pgStatLocalContext unless
it has read the stats file similar to other cases. So probably, we
should allocate it in pgStatLocalContext when we read 'R' message in
pgstat_read_statsfiles. Also, the function pgstat_get_replslot_entry
should not use pgStatLocalContext to allocate the hash table.
2.
+ if (replSlotStatHash != NULL)
+ (void) hash_search(replSlotStatHash,
+    (void *) &(msg->m_slotname),
+    HASH_REMOVE,
+    NULL);

Why have you changed this part from using NameStr?
3.
+# Check that replicatoin slot stats are expected.

Typo. replicatoin/replication


-- 
With Regards,
Amit Kapila.

Commits

Doc: Update logical decoding stats information.
- 0c6b92d9c6fb 14.0 landed
Fix tests for replication slots stats.
- fc69509131c3 14.0 landed
Update replication statistics after every stream/spill.
- 592f00f8dec6 14.0 landed
Fix the computation of slot stats for 'total_bytes'.
- 205f466282be 14.0 landed
Another try to fix the test case added by commit f5fc2f5b23.
- 51ef9173030c 14.0 landed
Use HTAB for replication slot statistics.
- 3fa17d37716f 14.0 landed
Fix test case added by commit f5fc2f5b23.
- c64dcc7fee5f 14.0 landed
Add information of total data processed to replication slot stats.
- f5fc2f5b23d1 14.0 landed
Use NameData datatype for slotname in stats.
- cca57c1d9bf7 14.0 landed