Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

On Wed, Nov 13, 2013 at 7:23 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Wed, Nov 13, 2013 at 4:05 PM, Haribabu kommi
> <haribabu.kommi@huawei.com> wrote:
>> On 01 October 2013 00:56 Amit Kapila wrote:
>>> On Mon, Sep 30, 2013 at 9:07 PM, Peter Eisentraut <peter_e@gmx.net>
>>> wrote:
>>> > On 9/28/13 3:05 AM, Amit Kapila wrote:
>>> >> Now as we have an agreement, I had updated patch for below left
>>> issues:
>>> >
>>
>> Some of the initial observation of the patch are,
>> 1. Patch is not applying against git head, needs a rebase.

Find the rebased version attached with this mail. I have removed
header inclusions of port.h and lwlock.h from guc.c, it works fine
without them.

>> 2. Patch doesn't contain the tests.
>    It was intentional and as per feedback for this patch. As for
> testing this feature, we need to put sleep after operation, so it was
> suggested to remove tests.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com