Re: Berserk Autovacuum (let's save next Mandrill)
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Darafei Komяpa Praliaskouski <me@komzpa.net>, Andres Freund <andres@anarazel.de>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Banck <mbanck@gmx.net>, David Rowley <david.rowley@2ndquadrant.com>
Date: 2019-09-10T11:19:46Z
Lists: pgsql-hackers
On Tue, Jul 23, 2019 at 1:53 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > To invoke autovacuum even on insert-only tables we would need check > the number of inserted tuples since last vacuum. I think we can keep > track of the number of inserted tuples since last vacuum to the stats > collector and add the threshold to invoke vacuum with INDEX_CLEANUP = > false. If an autovacuum worker confirms that the number of inserted > tuples exceeds the threshold it invokes vacuum with INDEX_CLEANUP = > false. However if the number of dead tuples also exceeds the > autovacuum thresholds (autovacuum_vacuum_threshold and > autovacuum_vacuum_scale_factor) it should invoke vacuum with > INDEX_CLEANUP = true. Therefore new threshold makes sense only when > it's lower than the autovacuum thresholds. > > I guess we can have one new GUC parameter to control scale factor. > Since only relatively large tables will require this feature we might > not need the threshold based the number of tuples. > Generally speaking, having more guc's for autovacuum and that too which are in some way dependent on existing guc's sounds bit scary, but OTOH whatever you wrote makes sense and can help the scenarios which this thread is trying to deal with. Have you given any thought to what Alvaro mentioned up-thread "certain tables would have some sort of partial scan that sets the visibility map. There's no reason to invoke the whole vacuuming machinery. I don't think this is limited to append-only tables, but rather those are just the ones that are affected the most."? This thread seems to be stalled for the reason that we don't have a clear consensus on what is the right solution for the problem being discussed. Alvaro, anyone has any thoughts on how we can move forward with this work? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Commits
-
Further improve stability fix for partition_aggregate test.
- 18d85e9b8a2b 13.0 landed
-
Improve stability fix for partition_aggregate test.
- 7cb0a423f914 13.0 landed
-
Attempt to stabilize partitionwise_aggregate test
- cefb82d49e21 13.0 landed
-
Fix race condition in statext_store().
- fe3036527a1f 13.0 landed
- 6c426cd43790 12.3 landed
-
Attempt to fix unstable regression tests, take 2
- 24566b359d09 13.0 landed
-
Attempt to fix unstable regression tests
- 2dc16efedc76 13.0 landed
-
Trigger autovacuum based on number of INSERTs
- b07642dbcd8d 13.0 landed
-
Fix upper limit for vacuum_cleanup_index_scale_factor
- 4d54543efa5e 11.0 cited