Horton

Re: New standby_slot_names GUC in PG 17

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Muhammad Ikram <mmikram@gmail.com>, Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>
Date: 2024-06-26T06:09:45Z
Lists: pgsql-hackers 
On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
>
> 2 ====
>
> Should we rename StandbySlotNamesConfigData too?
>

How about SyncStandbySlotsConfigData?

> 3 ====
>
> Should we rename SlotExistsInStandbySlotNames too?
>

Similarly SlotExistsInSyncStandbySlots?

> 4 ====
>
> Should we rename validate_standby_slots() too?
>

And validate_sync_standby_slots()?

--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -1325,7 +1325,7 @@ Author: Michael Paquier <michael@paquier.xyz>

 <!--
 Author: Amit Kapila <akapila@postgresql.org>
-2024-03-08 [bf279ddd1] Introduce a new GUC 'standby_slot_names'.
+2024-03-08 [bf279ddd1] Introduce a new GUC 'synchronized_standby_slots'.

I am not sure if it is a good idea to change release notes in the same
commit as the code change. I would prefer to do it in a separate
commit.

-- 
With Regards,
Amit Kapila.

Commits

  1. Update release notes to reflect recent commit 0f934b0739.

  2. Rename standby_slot_names to synchronized_standby_slots.

  3. Add a new slot sync worker to synchronize logical slots.