Re: Introduce XID age and inactive timeout based replication slot invalidation
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add a test for commit ac0e33136a using the injection point.
- 8a695d7998be 18.0 landed
-
Invalidate inactive replication slots.
- ac0e33136abc 18.0 landed
-
Fix incorrect slot type in BuildTupleHashTableExt
- d96d1d5152f3 18.0 cited
-
Allow synced slots to have their inactive_since.
- 6f132ed693b6 17.0 landed
-
Change last_inactive_time to inactive_since in pg_replication_slots.
- 6d49c8d4b4f4 17.0 landed
-
Track last_inactive_time in pg_replication_slots.
- a11f330b5584 17.0 landed
-
Track invalidation_reason in pg_replication_slots.
- 6ae701b4378d 17.0 landed
-
Add option force_initdb to PostgreSQL::Test::Cluster:init()
- ff9e1e764fcc 17.0 cited
-
Add a failover option to subscriptions.
- 776621a5e479 17.0 cited
-
Allow setting failover property in the replication command.
- 73292404370c 17.0 cited
-
Allow to enable failover property for replication slots via SQL API.
- c393308b69d2 17.0 cited
-
Track conflict_reason in pg_replication_slots.
- 007693f2a3ac 17.0 cited
-
Log messages for replication slot acquisition and release.
- 7c3fb505b14e 17.0 cited
-
Remove vacuum_defer_cleanup_age
- 1118cd37eb61 16.0 cited
-
Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids
- be504a3e974d 16.0 cited
-
meson: Add initial version of meson based build system
- e6927270cd18 16.0 cited
On Wed, Sep 4, 2024 at 9:17 AM shveta malik <shveta.malik@gmail.com> wrote: > > On Tue, Sep 3, 2024 at 3:01 PM shveta malik <shveta.malik@gmail.com> wrote: > > > > > > 1) > > I see that ReplicationSlotAlter() will error out if the slot is > > invalidated due to timeout. I have not tested it myself, but do you > > know if slot-alter errors out for other invalidation causes as well? > > Just wanted to confirm that the behaviour is consistent for all > > invalidation causes. > > I was able to test this and as anticipated behavior is different. When > slot is invalidated due to say 'wal_removed', I am still able to do > 'alter' of that slot. > Please see: > > Pub: > slot_name | failover | synced | inactive_since | > invalidation_reason > -------------+----------+--------+----------------------------------+--------------------- > mysubnew1_1 | t | f | 2024-09-04 08:58:12.802278+05:30 | > wal_removed > > Sub: > newdb1=# alter subscription mysubnew1_1 disable; > ALTER SUBSCRIPTION > > newdb1=# alter subscription mysubnew1_1 set (failover=false); > ALTER SUBSCRIPTION > > Pub: (failover altered) > slot_name | failover | synced | inactive_since | > invalidation_reason > -------------+----------+--------+----------------------------------+--------------------- > mysubnew1_1 | f | f | 2024-09-04 08:58:47.824471+05:30 | > wal_removed > > > while when invalidation_reason is 'inactive_timeout', it fails: > > Pub: > slot_name | failover | synced | inactive_since | > invalidation_reason > -------------+----------+--------+----------------------------------+--------------------- > mysubnew1_1 | t | f | 2024-09-03 14:30:57.532206+05:30 | > inactive_timeout > > Sub: > newdb1=# alter subscription mysubnew1_1 disable; > ALTER SUBSCRIPTION > > newdb1=# alter subscription mysubnew1_1 set (failover=false); > ERROR: could not alter replication slot "mysubnew1_1": ERROR: can no > longer get changes from replication slot "mysubnew1_1" > DETAIL: The slot became invalid because it was inactive since > 2024-09-04 08:54:20.308996+05:30, which is more than 0 seconds ago. > HINT: You might need to increase "replication_slot_inactive_timeout.". > > I think the behavior should be same. > We should not allow the invalid replication slot to be altered irrespective of the reason unless there is any benefit. -- With Regards, Amit Kapila.