Horton

Re: Conflict detection for multiple_unique_conflicts in logical replication

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Date: 2025-03-21T10:08:03Z
Lists: pgsql-hackers

Attachments

On Fri, Mar 21, 2025 at 1:48 PM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Fri, Mar 21, 2025 at 12:50 PM Nisha Moond wrote:
>
> > Thanks, Hou-san, for the review and fix patches. I’ve incorporated
> > your suggestions.
> > Attached are the v7 patches, including patch 002, which implements
> > stats collection for 'multiple_unique_conflicts' in pg_stat_subscription_stats.
>
> Thanks for updating the patches.
>
> Here are some more comments:
>
> 1.
>
> The comments atop of ReportApplyConflict() should be updated to reflect the
> updates made to the input parameters.
>

Right, I also noticed this and updated it in the attached. Apart from
this, I have made a number of cosmetic changes in the attached. Please
review and include it in the next version unless you see any problem
with it.

-- 
With Regards,
Amit Kapila.

Commits

  1. Stablize tests added in 3abe9dc188.

  2. Fix the typo in the test case added in 73eba5004a.

  3. Detect and Log multiple_unique_conflicts type conflict.