Horton

Re: Fix for segfault in logical replication on master

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>
Cc: Japin Li <japinli@hotmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, "akapila@postgresql.org" <akapila@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-28T08:39:44Z
Lists: pgsql-hackers 
On Tue, Jun 22, 2021 at 9:18 AM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
>
> On Tuesday, June 22, 2021 11:08 AM Japin Li <japinli@hotmail.com> wrote:
> > > Your patch appears to be on the lines we discussed but I would prefer
> > > to get it done after Beta2 as this is just a minor code improvement.
> > > Can you please send the change as a patch file instead of copy-pasting
> > > the diff at the end of the email?
> >
> > Thanks for your review! Attached v1 patch.
> Your patch can be applied to the HEAD.
> And, I also reviewed your patch, which seems OK.
> Make check-world has passed with your patch in my env as well.
>

Pushed, thanks!

-- 
With Regards,
Amit Kapila.

Commits

  1. Improve RelationGetIdentityKeyBitmap().

  2. Handle no replica identity index case in RelationGetIdentityKeyBitmap.

  3. Fix Logical Replication of Truncate in synchronous commit mode.