Horton

Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-17T10:36:34Z
Lists: pgsql-hackers 
On Thu, Jan 23, 2025 at 6:42 PM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
> Fixed the given comments. The attached patch contains the suggested changes.
>

I am fine with giving a WARNING for max_slot_wal_keep_size but I don't
think we need a test for each and every setting required for
pg_createsubscriber. This will add time to the tests without adding
much value. So, I don't think this patch deserves an additional test.

-- 
With Regards,
Amit Kapila.

Commits

  1. Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.

  2. Improve grammar of options for command arrays in TAP tests