Re: Fastpath while arranging the changes in LSN order in logical decoding
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-03-24T12:46:28Z
Lists: pgsql-hackers
On Mon, Mar 9, 2020 at 11:07 PM Andres Freund <andres@anarazel.de> wrote: > > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote: > > IMHO, if we conclude that because there is no performance gain so we > > don't want to add one extra path in the code then we might want to > > remove that TODO from the code so that we don't spend time for > > optimizing this in the future. > > +1 > Dilip, are you planning to do more tests for this? Anyone else wants to do more tests? If not, based on current results, we can remove that TODO and in future, if someone comes with a test case to show benefit for adding fastpath, then we can consider the patch proposed by Dilip. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Commits
-
logical decoding: Remove TODO about unnecessary optimization.
- 112b006fe79b 13.0 landed
-
Stamp 12.2.
- 45b88269a353 12.2 cited