Re: [PATCH] Fix stale relation close in sequence synchronization
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-30T11:20:27Z
Lists: pgsql-hackers
On Thu, Apr 30, 2026 at 12:16 PM Ayush Tiwari <ayushtiwari.slg01@gmail.com> wrote: > > On Thu, 30 Apr 2026 at 11:27, vignesh C <vignesh21@gmail.com> wrote: >> >> >> Consider updating the error reported in report_sequence_errors to >> convey that the failure could be due to either a missing sequence or >> insufficient privileges (e.g., "missing sequence or insufficient >> privilege on publisher"). While making this change, also update the >> missing_seqs_idx variable name and the associated comments to >> accurately reflect the broader scope of the condition. > > > Agreed. > Sequence sync can also be skipped if the same sequence is a temporary sequence from some other session on publisher. So, the change in v5 was also incomplete if we want to make it more generic than now. I have pushed v4 for now but if you or Vignesh would like to make the message more generic, feel free to propose a new patch. -- With Regards, Amit Kapila.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix BF failure introduced in commit 2bf6c9ff71.
- f67dbd8398c0 19 (unreleased) landed
-
Fix double table_close of sequence_rel in copy_sequences().
- 2bf6c9ff71c9 19 (unreleased) landed
-
Fix BF failure introduced by commit b3f6b14cf4.
- def0ce337068 17.0 cited