Re: row filtering for logical replication
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Thu, Sep 9, 2021 at 11:43 AM Peter Smith <smithpb2250@gmail.com> wrote: > > PSA my new incremental patch (v28-0002) that introduces row filter > validation for the publish mode "delete". The validation requires that > any columns referred to in the filter expression must also be part of > REPLICA IDENTITY or PK. > > [This v28-0001 is identical to the most recently posted rebased base > patch. It is included again here only so the cfbot will be happy] > > ~~ > > A requirement for some filter validation like this has been mentioned > several times in this thread [1][2][3][4][5]. > > I also added some test code for various kinds of replica identity. > > A couple of existing tests had to be modified so they could continue > to work (e.g. changed publish = "insert" or REPLICA IDENTITY FULL) > > Feedback is welcome. > > ~~ > > NOTE: This validation currently only checks when the filters are first > created. Probably there are many other scenarios that need to be > properly handled. What to do if something which impacts the existing > filter is changed? > > e.g. > - what if the user changes the publish parameter using ALTER > PUBLICATION set (publish="delete") etc? > - what if the user changes the replication identity? > - what if the user changes the filter using ALTER PUBLICATION in a way > that is no longer compatible with the necessary cols? > - what if the user changes the table (e.g. removes a column referred > to by a filter)? > - what if the user changes a referred column name? > - more... > > (None of those are addressed yet - thoughts?) > I think we need to remove the filter or the table from publication in such cases. Now, one can think of just removing the condition related to the column being removed/changed in some way but I think that won't be appropriate because it would change the meaning of the filter. We are discussing similar stuff in the column filter thread and we might want to do the same for row filters as well. I would prefer to remove the table in both cases as Rahila has proposed in the column filter patch. -- With Regards, Amit Kapila.