Horton

Re: typos

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, David Rowley <dgrowleyml@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Fabien COELHO <coelho@cri.ensmp.fr>, Amit Kapila <akapila@postgresql.org>
Date: 2022-04-11T10:45:23Z
Lists: pgsql-hackers 
On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER
> > SUBSCRIPTION ... SKIP).
>
> Thank you for the patch! I've looked at 0012 patch. Regarding the
> following part:
>
>     <function>pg_replication_origin_advance()</function></link> function
> -   transaction.  Before using this function, the subscription needs
> to be disabled
> +   XXX? transaction.  Before using this function, the subscription
> needs to be disabled
>     temporarily either by <command>ALTER SUBSCRIPTION ...
> DISABLE</command> or, the
>
> we can remove "transaction", it seems a typo.
>

Right.

> The rest looks good to me.
>

+1. I'll take care of pushing this one tomorrow unless we have more
comments on this part.

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix typos and grammar in code and test comments

  2. Standardize references to Zstandard as <productname>

  3. CREATE PUBLICATION ref: Minor tweaks to row filters

  4. Add missing spaces after single-line comments

  5. Docs: fix some spelling mistakes and also do some wordsmithing

  6. Remove extraneous blank lines before block-closing braces

  7. Docs: wording improvement for compute_query_id = regress

  8. Docs: tidy up various usages of the productname tag

  9. Docs: adjust wording about basebackup_to_shell's required_role GUC

  10. Docs: adjust pg_upgrade syntax to mark -B as optional

  11. Docs: avoid confusing use of the word "synchronized"

  12. Fix grammatical errors and typos in logical replication docs.

  13. Docs: Mention that relpersistence is for sequences now too

  14. Fix various typos and spelling mistakes in code comments

  15. Docs: Fix various mistakes and typos