Horton

Re: Handle infinite recursion in logical replication setup

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "Jonathan S. Katz" <jkatz@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>
Date: 2022-07-27T02:53:19Z
Lists: pgsql-hackers 
On Tue, Jul 26, 2022 at 10:23 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Tue, Jul 26, 2022 at 2:09 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> >
> > I am not really sure how much we gain by maintaining consistency with
> > slot_name because if due to this we have to change the error messages
> > as well then it can create an inconsistency with reserved origin
> > names. Consider message: DETAIL:  Origin names "any", "none", and
> > names starting with "pg_" are reserved. Now, if we change this to
> > "ANY", "NONE" in the above message, it will look a bit odd as "pg_"
> > starts with lower case letters.
> >
>
> Sure, the message looks a bit odd with the quotes like you wrote
> above, but I would not suggest to change it that way - I was thinking
> more like below (which is similar to the style the slot_name messages
> use)
>
> CURRENT
> DETAIL:  Origin names "any", "none", and names starting with "pg_" are reserved.
>
> SUGGESTED
> DETAIL:  Origin names ANY, NONE, and names starting with "pg_" are reserved.
>

I see your point but not sure if that is an improvement over the
current one, so, let's wait and see if we get some other votes in
favor of your suggestion.

-- 
With Regards,
Amit Kapila.

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues