Re: Explain buffers wrong counter with parallel plans

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, "Jonathan S. Katz" <jonathan.katz@excoventures.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Adrien Nayrat <adrien.nayrat@anayrat.info>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-08-13T05:03:21Z
Lists: pgsql-hackers
On Fri, Aug 3, 2018 at 6:56 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Aug 3, 2018 at 4:39 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> I have noticed that part of the comment atop ExecShutdownNode is now
>> redundant.  See attached edit_comments_shutdown_node_v1, let me know
>> if you think otherwise.
>
> Oh, yes, that should be adjusted.
>

Pushed the patch for same.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


Commits

  1. Adjust comment atop ExecShutdownNode.

  2. Prohibit shutting down resources if there is a possibility of back up.

  3. Fix buffer usage stats for parallel nodes.

  4. Match the buffer usage tracking for leader and worker backends.

  5. Improve division of labor between execParallel.c and nodeGather[Merge].c.