Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, Nisha Moond <nisha.moond412@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: 2025-03-27T06:45:51Z
Lists: pgsql-hackers 
On Wed, Mar 26, 2025 at 4:02 PM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>

Let's combine 0001 and 0002.

A few minor comments:
*
+       If database name is not specified in publisher-server, it will try to
+       connect with postgres/template1 database to fetch the databases from
+       primary.

Can we change the above to: "If the database name is not specified in
publisher-server, the postgres database will be used, or if that does
not exist, template1 will be used."

*
+       Create one subscription on the target server for each non-template
+       database on the source server that allows connections, excluding
+       template databases or databases with connection restrictions.

The following text proposed by Euler seems better: "Create one
subscription per database on the target server. Exceptions are
template databases and databases that don't allow connections."

Please use this one at the above and other places where required.

-- 
With Regards,
Amit Kapila.

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.