Re: Added schema level support for publication.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>,
"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-09-06T08:18:57Z
Lists: pgsql-hackers
On Mon, Sep 6, 2021 at 9:53 AM tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com> wrote: > > On Thursday, September 2, 2021 2:36 PM vignesh C <vignesh21@gmail.com> wrote: > > > > On Wed, Sep 1, 2021 at 11:14 AM tanghy.fnst@fujitsu.com > > <tanghy.fnst@fujitsu.com> wrote: > > > > > > 3. When using '\dn+', I noticed that the list of publications only contains the > > > publications for "SCHEMA", "FOR ALL TABLES" publications are not shown. Is it > > designed on purpose? > > > (The result of '\d+' lists the publications of "SCHEAME" and "FOR ALL TABLES"). > > > > > > For example: > > > create schema sch1; > > > create table sch1.tbl(a int); > > > create publication pub_schema for all tables in schema sch1; > > > create publication pub_all_tables for all tables; > > > > I'm not sure if it is intentional or not, Do you want to post the > > question in a separate thread and see if that should be handled? > > > > Sorry, maybe I didn't make my last question clearly enough. > > In HEAD(where schema level is not supported for publication), there is no publication > information in the result of '\dn+'. > > With this schema patch, '\dn+' shows the publications related to the schema, but ALL > TABLES publications are not shown. Do you think we should add ALL TABLES publications, too? > No, I don't think we need to display For All Tables publication under \dn+. It is already shown with \d+ <table_name> command. -- With Regards, Amit Kapila.
Commits
-
Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
-
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
-
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
-
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited