Horton

Re: Skipping logical replication transactions on subscriber side

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-12-09T02:47:27Z
Lists: pgsql-hackers 
On Wed, Dec 8, 2021 at 4:36 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Wed, Dec 8, 2021 at 5:54 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Dec 8, 2021 at 12:36 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> > > On Wed, Dec 8, 2021 at 3:50 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > > On Wed, Dec 8, 2021 at 11:48 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > > > >
> > > > > >
> > > > > > Can't we think of just allowing prepare in this case and updating the
> > > > > > skip_xid only at commit time? I see that in this case, we would be
> > > > > > doing prepare for a transaction that has no changes but as such cases
> > > > > > won't be common, isn't that acceptable?
> > > > >
> > > > > In this case, we will end up committing both the prepared (empty)
> > > > > transaction and the transaction that updates the catalog, right?
> > > > >
> > > >
> > > > Can't we do this catalog update before committing the prepared
> > > > transaction? If so, both in prepared and non-prepared cases, our
> > > > implementation could be the same and we have a reason to accomplish
> > > > the catalog update in the same transaction for which we skipped the
> > > > changes.
> > >
> > > But in case of a crash between these two transactions, given that
> > > skip_xid is already cleared how do we know the prepared transaction
> > > that was supposed to be skipped?
> > >
> >
> > I was thinking of doing it as one transaction at the time of
> > commit_prepare. Say, in function apply_handle_commit_prepared(), if we
> > check whether the skip_xid is the same as prepare_data.xid then update
> > the catalog and set origin_lsn/timestamp in the same transaction. Why
> > do we need two transactions for it?
>
> I meant the two transactions are the prepared transaction and the
> transaction that updates the catalog. If I understand your idea
> correctly, in apply_handle_commit_prepared(), we update the catalog
> and set origin_lsn/timestamp. These are done in the same transaction.
> Then, we commit the prepared transaction, right?
>

I am thinking that we can start a transaction, update the catalog,
commit that transaction. Then start a new one to update
origin_lsn/timestamp, finishprepared, and commit it. Now, if it
crashes after the first transaction, only commit prepared will be
resent again and this time we don't need to update the catalog as that
entry would be already cleared.

-- 
With Regards,
Amit Kapila.

Commits

  1. Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.

  2. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  3. Add ALTER SUBSCRIPTION ... SKIP.

  4. Optionally disable subscriptions on error.

  5. Update docs of logical replication for commit 8d74fc96db.

  6. Respect permissions within logical replication.

  7. Fix regression test failure caused by commit 8d74fc96db.

  8. Add a view to show the stats of subscription workers.

  9. Add logical change details to logical replication worker errcontext.

  10. Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.

  11. Fix typo in protocol.sgml.

  12. Remove unused argument in apply_handle_commit_internal().

  13. Fix replication of in-progress transactions in tablesync worker.

  14. Reorder pg_sequence columns to avoid alignment issue