Re: pg_get_publication_tables() output duplicate relid
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
Alvaro Herrera <alvherre@alvh.no-ip.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-08T10:16:50Z
Lists: pgsql-hackers
On Thu, Dec 2, 2021 at 8:42 AM Amit Langote <amitlangote09@gmail.com> wrote: > > On Thu, Dec 2, 2021 at 9:44 houzj.fnst@fujitsu.com > <houzj.fnst@fujitsu.com> wrote: > > On Wed, Dec 1, 2021 3:01 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > On Mon, Nov 22, 2021 at 12:55 PM Amit Langote > > > > > <amitlangote09@gmail.com> wrote: > > > > > > On second thought, I agree that de-duplicating partitions from > > > > > > this view is an improvement. > > > > > > > > > > Fair enough. Hou-San, Can you please submit the updated patch after > > > > > fixing any pending comments including the test case? > > > > > > > > Attach the updated patch which address the comments so far. > > > > > > > > The patch only adds a testcase in publication.sql because the > > > > duplicate output doesn't cause unexpected behavior in pub-sub test. > > > > > > Thanks, the patch looks good to me. I have slightly changed the commit > > > message in the attached. I would like to commit this only in HEAD as there is no > > > user complaint about this and it might not stop any user's service unless it relies > > > on this view's output for the initial table synchronization. > > The patch looks good to me too in that it gets the job done. > Pushed. -- With Regards, Amit Kapila.
Commits
-
Improve invalidation handling in pgoutput.c.
- 7f481b8d3884 15.0 cited
-
De-duplicate the result of pg_publication_tables view.
- a61bff2bf479 15.0 landed
-
Doc: Add "Attach Partition" limitation during logical replication.
- 64e8456bbde1 13.6 landed
- 4b8eec716a52 14.2 landed
- eb7828f54a44 15.0 landed