Horton

Re: statement_timeout is not working as expected with postgres_fdw

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-20T11:33:05Z
Lists: pgsql-hackers 
On Thu, May 18, 2017 at 7:56 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, May 17, 2017 at 6:57 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> +1.  Why not similar behavior for any other statements executed in
>> this module by do_sql_command?
>
> The other cases are not quite the same situation.  It would be good to
> accept interrupts in all cases,
>

Yes, that's one of the main things I was indicating for making the
behavior same, but again that could be done as a separate patch as
well.

> but there's no problem with a session
> continuing to be used after a failure in configure_remote_session()
> because the connection hasn't been entered in the hash table at that
> point yet, and the TRY/CATCH block in connect_pg_server() ensures that
> the connection also gets closed.  So we don't need to worry about
> those statements leaving behind messed-up sessions; they won't; only
> the transaction control commands have that part of the problem.
>

Agreed.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. postgres_fdw: Allow cancellation of transaction control commands.

  2. Allow queries submitted by postgres_fdw to be canceled.

  3. Fix multiple problems in postgres_fdw query cancellation logic.