Re: Inconsistency in determining the timestamp of the db statfile.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>,
Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Fujii Masao <masao.fujii@oss.nttdata.com>,
Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-11T02:52:56Z
Lists: pgsql-hackers
On Thu, Sep 10, 2020 at 6:42 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > On 2020-Sep-10, Amit Kapila wrote: > > > On Thu, Sep 10, 2020 at 1:03 PM Magnus Hagander <magnus@hagander.net> wrote: > > > The comments already say what you said in the second suggestion:"The > > caller must rely on timestamp stored in *ts iff the function returns > > true.". Read iff "as if and only if" > > I think "must" should be "may" there, if we're nitpicking. > Here, we want to say that "caller can rely on *ts only if the function returns true". If we replace 'must' with 'may' then it seems to me we are trying to say that caller can ignore the timestamp value, if so, why at first place caller has called this function. -- With Regards, Amit Kapila.
Commits
-
Fix inconsistency in determining the timestamp of the db statfile.
- 03c7f1f37a1f 14.0 landed
-
Split pgstat file in smaller pieces
- 187492b6c2e8 9.3.0 cited