Re: row filtering for logical replication
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Mon, Jan 24, 2022 at 1:19 PM Greg Nancarrow <gregn4422@gmail.com> wrote: > > On Mon, Jan 24, 2022 at 5:09 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > But that is not what I am seeing in Logs with a test case where the > > row filter column has NULL values. Could you please try that see what > > is printed in LOG? > > > > You can change the code to make the elevel as LOG to get the results > > easily. The test case I tried is as follows: > > Node-1: > > postgres=# create table t1(c1 int, c2 int); > > CREATE TABLE > > postgres=# create publication pub for table t1 WHERE (c1 > 10); > > CREATE PUBLICATION > > > > Node-2: > > postgres=# create table t1(c1 int, c2 int); > > CREATE TABLE > > postgres=# create subscription sub connection 'dbname=postgres' publication pub; > > NOTICE: created replication slot "sub" on publisher > > CREATE SUBSCRIPTION > > > > After this on publisher-node, I see the LOG as "LOG: row filter > > evaluates to false (isnull: true)". I have verified that in the code > > as well (in slot_deform_heap_tuple), we set the value as 0 for isnull > > which matches above observation. > > > > There are obviously multiple code paths under which a column can end up as NULL. > Doing one NULL-column test case, and finding here that > "DatumGetBool(ret)" is "false" when "isnull" is true, doesn't prove it > will be like that for ALL possible cases. > Sure, I just wanted to see the particular test which leads to failure so that I or others can know (or debug) why in some cases it behaves differently. Anyway, for others, the below test can show the results: CREATE TABLE tab_rowfilter_1 (a int primary key, b text); alter table tab_rowfilter_1 replica identity full ; INSERT INTO tab_rowfilter_1 (a, b) VALUES (1600, 'test 1600'); CREATE PUBLICATION pub FOR TABLE tab_rowfilter_1 WHERE (a > 1000 AND b <> 'filtered'); UPDATE tab_rowfilter_1 SET b = NULL WHERE a = 1600; So, we can change this DEBUG log. -- With Regards, Amit Kapila.