Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndquadrant.com>, Bruce Momjian <bruce@momjian.us>, Martijn van Oosterhout <kleptog@svana.org>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Josh Berkus <josh@agliodbs.com>, Fujii Masao <masao.fujii@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2013-09-30T19:26:04Z

Lists: pgsql-hackers

Attachments

alter_system_v9.patch (application/octet-stream) patch v9

On Mon, Sep 30, 2013 at 9:07 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On 9/28/13 3:05 AM, Amit Kapila wrote:
>> Now as we have an agreement, I had updated patch for below left issues:
>
> Regression tests are failing.

   Thanks for informing. I am sorry for not running regression before
sending patch.

   Reason for failure was that source for GUC in new function
validate_conf_option() was hardcoded to PGC_S_FILE which was okay for
Alter System, but
   not for SET path. I had added new parameter source in this function
and get the value of source when this is called from SET path.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com