Horton

Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Petr Jelinek <petr@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Henry Hinze <henry.hinze@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-11-26T12:36:40Z
Lists: pgsql-bugs

Attachments

On Thu, Nov 26, 2020 at 12:24 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
>
> - And I also thought it would be neater to simply move the
> process_syncing_tables by one line so you can do the stream file
> resource cleanup explicitly the normal way instead of relying on
> implicit cleanup as the tablesync process exits.
>

Okay, I see your point, so changed it accordingly and fixed the code
comments as suggested by you. Does this address all your
concerns/suggestions?

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix replication of in-progress transactions in tablesync worker.

  2. Review logical replication tablesync code

  3. Restore replication protocol's duplicate command tags