Re: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-25T03:35:54Z
Lists: pgsql-hackers
On Tue, Mar 25, 2025 at 8:31 AM Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote: > > Dear hackers, > > While reading the code, I found $SUBJECT. It says: > > ``` > /* > * Publication relation/schema map syscache invalidation callback > * > * Called for invalidations on pg_publication and pg_namespace. > */ > static void > rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue) > ``` > > But this won't be called for invalidating pg_publication. It should have been > updated by 3abe9dc1, but it was an oversight. > Agreed and thanks for the patch. -- With Regards, Amit Kapila.
Commits
-
Fix an oversight in 3abe9dc188.
- b87ced747df7 18.0 landed