Re: dropdb --force

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Ryan Lambert <ryan@rustprooflabs.com>, Thomas Munro <thomas.munro@gmail.com>, Anthony Nowocien <anowocien@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Date: 2019-11-08T10:50:11Z
Lists: pgsql-hackers
On Fri, Nov 8, 2019 at 4:13 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:
>
>>> Did you get a chance to look at the other related patch posted by me
>>> [1]?  I have asked it before as well because I think that need to go
>>> before this.  We need to avoid errors to happen after terminating the
>>> connections as otherwise, the termination of other databases will go
>>> be of no use.
>>>
>>> I have added the comment and changed one condition in tab-completion
>>> as otherwise, it was allowing tab completion for the following syntax:
>>> "drop database db1 , FORCE" which doesn't make sense to me.  Please,
>>> find the result attached.  Let me know what you think?
>>>
>>> [1] - https://www.postgresql.org/message-id/CAA4eK1%2BqhLkCYG2oy9xug9ur_j%3DG2wQNRYAyd%2B-kZfZ1z42pLw%40mail.gmail.com
>>
>>
>> I'll check it today
>
>
> I checked it for 800 active clients, and it is working without problems. I run "check-world" without problem too.
>
> The patch looks well, I have not any comments.
>

Thanks, but are you planning to look at the other thread mentioned in
my previous email?  We need to finish that before this.



-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



Commits

  1. Add tests for '-f' option in dropdb utility.

  2. Move pump_until to TestLib.pm.

  3. Add the support for '-f' option in dropdb utility.

  4. Introduce the 'force' option for the Drop Database command.

  5. Improve CREATE/DROP/RENAME DATABASE so that when failing because the source