Re: Parallel Index Scans
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Anastasia Lubennikova <lubennikovaav@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>, Rahila Syed <rahilasyed.90@gmail.com>
Date: 2017-01-23T06:07:34Z
Lists: pgsql-hackers
On Fri, Jan 20, 2017 at 7:29 AM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote: > > On Thu, Jan 19, 2017 at 1:18 AM, Amit Kapila <amit.kapila16@gmail.com> > wrote: >> > >> > +extern BlockNumber _bt_parallel_seize(IndexScanDesc scan, bool >> > *status); >> > +extern void _bt_parallel_release(IndexScanDesc scan, BlockNumber >> > scan_page); >> > >> > Any better names for the above functions, as these function will >> > provide/set >> > the next page that needs to be read. >> > >> >> These functions also set the state of scan. IIRC, these names were >> being agreed between Robert and Rahila as well (suggested offlist by >> Robert). I am open to change if you or others have any better >> suggestions. > > > I didn't find any better names other than the following, > > _bt_get_next_parallel_page > _bt_set_next_parallel_page > I am not sure using *_next_* here will convey the message because for backward scans we set the last page. I am open to changing the names of functions if committer and or others prefer the names suggested by you. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Commits
-
Replace min_parallel_relation_size with two new GUCs.
- 51ee6f3160d2 10.0 landed
-
Factor out logic for computing number of parallel workers.
- 716c7d4b242f 10.0 cited
-
Support condition variables.
- e8ac886c2477 10.0 cited
-
Allow parallel custom and foreign scans.
- 69d34408e5e7 9.6.0 cited
-
Add a C API for parallel heap scans.
- ee7ca559fcf4 9.6.0 cited