Horton

Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Li Japin <japinli@hotmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-06T05:50:38Z
Lists: pgsql-hackers 
On Fri, Aug 6, 2021 at 10:09 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
>
> But, isn't this happening because of your suggestion to compare the
> current set of relations with relations from publications that doesn't
> need to be removed? Do we have better ideas to fix or shall we just
> say that we will refresh based on whatever current set of relations
> are present in publication to be dropped?
>

The other options could be that (a) for drop publication, we refresh
all the publications, (b) for both add/drop publication, we refresh
all the publications.

Any better ideas?

As this is introduced in PG-14 via the below commit, I am adding
authors and committer to see if they have any better ideas.

commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f
Author: Peter Eisentraut <peter@eisentraut.org>
Date:   Tue Apr 6 10:44:26 2021 +0200

    ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

 Author: Japin Li <japinli@hotmail.com>
 Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>


-- 
With Regards,
Amit Kapila.

Commits

  1. Fix Alter Subscription's Add/Drop Publication behavior.

  2. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION