Horton

Fix warnings and typo in dshash

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-03T06:57:12Z
Lists: pgsql-hackers

Attachments

I am seeing below warnings (on Win7) in dshash.c

1>  dshash.c
1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
1>src/backend/lib/dshash.c(679): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
1>src/backend/lib/dshash.c(713): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)

Attached a patch to fix the above warning.

I have noticed a typo in dshash.h for which a separate patch is attached.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Minor clean-up in dshash.{c,h}.

  2. Suppress compiler warnings in dshash.c.

  3. Fix macro-redefinition warning on MSVC.