Re: Added schema level support for publication.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>,
"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-08-06T10:32:00Z
Lists: pgsql-hackers
On Fri, Aug 6, 2021 at 2:16 PM vignesh C <vignesh21@gmail.com> wrote: > > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > Few more comments: > > =================== > > 1. Do we need the previous column 'puballtables' after adding pubtype > > or pubkind in pg_publication? > > I felt this should be retained as old client will still be using puballtables, like in case of old client executing \dRp+ commands. > But do we guarantee that old clients work with newer server versions? For example, psql docs say: "psql works best with servers of the same or an older major version. Backslash commands are particularly likely to fail if the server is of a newer version than psql itself." [1] (See Notes Section). Similarly, pg_dump docs say: "However, pg_dump cannot dump from PostgreSQL servers newer than its own major version; it will refuse to even try, rather than risk making an invalid dump." [2] (See Notes Section). It seems Sawada-San has the same question and IIUC docs suggest we don't need such compatibility, so what makes you think we need it? [1] - https://www.postgresql.org/docs/devel/app-psql.html [2] - https://www.postgresql.org/docs/devel/app-pgdump.html -- With Regards, Amit Kapila.
Commits
-
Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
-
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
-
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
-
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited