Re: Amcheck verification of GiST and GIN

Thom Brown <thom@linux.com>

From: Thom Brown <thom@linux.com>

To: Tomas Vondra <tomas@vondra.me>

Cc: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Kirill Reshke <reshkekirill@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, Alexander Lakhin <exclusion@gmail.com>, Andrey Borodin <amborodin86@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-06-17T14:19:41Z

Lists: pgsql-hackers

On Mon, 16 Jun 2025 at 21:00, Tomas Vondra <tomas@vondra.me> wrote:
>
> On 6/16/25 21:09, Arseniy Mukhin wrote:
> > On Mon, Jun 16, 2025 at 6:58 PM Tomas Vondra <tomas@vondra.me> wrote:
> >>
> >> Thanks.
> >>
> >> I went through the patches, polished the commit messages and did some
> >> minor tweaks in patch 0002 (to make the variable names a bit more
> >> consistent, and reduce the scope a little bit). I left it as a separate
> >> patch to make the changes clearer, but it should be merged into 0002.
> >>
> >> Please read through the commit messages, and let me know if I got some
> >> of the details wrong (or not clear enough). Otherwise I plan to start
> >> pushing this soon (~tomorrow).
> >
> > LGTM.
> > Noticed a few typos in messages:
> > in v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch
> >    - parent key is creator
> >    - as the core incorrectly expected
> > and 'Arseniy Mikhin' in some patches.
> >
>
> Thanks for noticing those typos, especially the one in the name.

Do today's commits clear this from the PostgreSQL 18 Open Items list?

Thom